Return-Path: <tiff-bounces@lists.maptools.org>
Received: from mailgate002.isp.belgacom.be (mailgate002.isp.belgacom.be [195.238.6.87])
        by maildelivery012.isp.belgacom.be (8.12.11.20060308/8.12.11/Skynet-IN-2.32) with ESMTP id l6BNKTsn004099
        for <joris.at.lebbeke@skynet.be>; Thu, 12 Jul 2007 01:20:29 +0200
        (envelope-from <tiff-bounces@lists.maptools.org>)
Received: from r153.dmsolutions.ca (HELO duke.maptools.org) ([209.217.116.153])
  by in.mx.skynet.be with ESMTP; 12 Jul 2007 01:20:27 +0200
Received: from duke.maptools.org (duke.maptools.org [127.0.0.1])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id l6BN7JSb017324;
	Wed, 11 Jul 2007 19:07:52 -0400
Received: from scooby.simplesystems.org (scooby.simplesystems.org
	[65.66.246.67])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id l6BN7CuO017321
	for <tiff@lists.maptools.org>; Wed, 11 Jul 2007 19:07:13 -0400
Received: from blade.simplesystems.org (blade.simplesystems.org [65.66.246.74])
	by scooby.simplesystems.org (8.12.10+Sun/8.12.10) with ESMTP id
	l6BN75W7029196; Wed, 11 Jul 2007 18:07:05 -0500 (CDT)
Date: Wed, 11 Jul 2007 18:07:05 -0500 (CDT)
From: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
X-X-Sender: bfriesen@blade.simplesystems.org
To: Kevin Myers <kmyers1@clearwire.net>
Subject: Re: [Tiff] Re: Enhancements for tiffdump and tiffset
In-Reply-To: <0b3901c7c40d$2712a220$6a08d9a6@gateway>
Message-ID: <Pine.SOC.4.60.0707111803080.922@blade.simplesystems.org>
References: <0b3901c7c40d$2712a220$6a08d9a6@gateway>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: tiff@lists.maptools.org
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-UIDL: 000000000023ceae.000025fc
X-MSP-STORE: Thu, 12 Jul 2007 01:20:33 --21-99
Status:   

On Wed, 11 Jul 2007, Kevin Myers wrote:
>
> I located a version of diff that can be run under Windows to prepare patches 
> for the enhancements that I implemented for tiffdump and tiffset.  However, 
> the changes that I made include a lot of white space changes due to greater 
> indentation of pre-existing blocks of code within new if statement blocks. Do 
> you want to see all of these white space changes in the diff output, or 
> should I tell diff to ignore whitespace or indentation differences?

I recommend using the diff option '-u'.  The most important concern is 
how easy it is is to automatically apply the patch.  White space is 
cheap.  The person who applies the patch can re-indent the code (after 
the patch is applied) as they see fit. The -u option selects a 
"unified context" diff.

Bob
======================================
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
