Return-Path: <awaresystems.be+caf_=filtered=awaresystems.be@gmail.com>
Delivered-To: filtered@awaresystems.be
Received: from mx-c.one.com (mx-c.one.com [91.198.169.50])
	by mail6.local (Postfix) with ESMTP id C212D8014F9E6
	for <filtered@awaresystems.be>; Wed,  1 May 2013 17:12:20 +0200 (CEST)
X-Virus-Scanned: by one.com
Received-SPF: pass (mx-c: domain of awaresystems.be+caf_=filtered=awaresystems.be@gmail.com designates 209.85.215.46 as permitted sender)
X-Greylist: whitelisted by SQLgrey-1.8.0-rc2
Received: from mail-la0-f46.google.com (mail-la0-f46.google.com [209.85.215.46])
	by mx-c.one.com (Postfix) with ESMTP id 852712211771
	for <filtered@awaresystems.be>; Wed,  1 May 2013 15:12:20 +0000 (UTC)
Received: by mail-la0-f46.google.com with SMTP id fs13so1405148lab.19
        for <filtered@awaresystems.be>; Wed, 01 May 2013 08:12:20 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20120113;
        h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received
         :domainkey-status:received-spf:x-gmail-fetch-info:delivered-to
         :x-virus-scanned:x-greylist:date:from:x-x-sender:to:in-reply-to
         :message-id:references:user-agent:mime-version:x-greylist:cc:subject
         :x-beenthere:x-mailman-version:precedence:list-id:list-unsubscribe
         :list-archive:list-post:list-help:list-subscribe:content-type
         :content-transfer-encoding:sender:errors-to;
        bh=RdM0PHX+XbA4HUkVQAZ3sCn5F/E0b82RJnSICUONrdo=;
        b=DE73e645/bqCtZ/BqCpmWOJa/8CiykN/al5NtDOAdt2a1nlGrVRaWy/1gxPkhelVHX
         bu9MStEm8kCGweJsCyMewglaVzcbcGwtdHwjeJiUEFmHVPYQ8loBaF97ZixFlEWheZWI
         IQpi5Ijm3Adwv8yUtyRYejbrJgHQhDDkbfQH9uxefCsX6aNRS+CBHMWtrfA4Xlfg/Um+
         l3G+ISSMW/443F1Q0X3lrUDuzAKxy9YSnzmAE5Fl0F9gOripGG7u4jA5T08mEP0ikBf2
         qmrUSxaGRODDTxXG9z+aK0Ce/+h3EejhXrSl4UzseruBAv2eSHYD8Kwk56gztO6KuoXn
         FvNA==
X-Received: by 10.112.181.163 with SMTP id dx3mr1254462lbc.126.1367421139998;
        Wed, 01 May 2013 08:12:19 -0700 (PDT)
X-Forwarded-To: filtered@awaresystems.be
X-Forwarded-For: awaresystems.be@gmail.com filtered@awaresystems.be
Delivered-To: awaresystems.be@gmail.com
Received: by 10.114.29.36 with SMTP id g4csp153402ldh;
        Wed, 1 May 2013 08:12:19 -0700 (PDT)
X-Received: by 10.112.173.136 with SMTP id bk8mr3300423lbc.24.1367421138908;
        Wed, 01 May 2013 08:12:18 -0700 (PDT)
DomainKey-Status: bad format
Received-SPF: neutral (google.com: 91.198.169.58 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) client-ip=91.198.169.58;
Received: by 10.152.99.84 with POP3 id eo20mf1050792lab.7;
        Wed, 01 May 2013 08:12:18 -0700 (PDT)
X-Gmail-Fetch-Info: info@awaresystems.be 1 pop.awaresystems.be 110 info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx-k.one.com (mx-k.one.com [91.198.169.58])
	by mail6.local (Postfix) with ESMTP id 4747B8014F9E8
	for <info@awaresystems.be>; Wed,  1 May 2013 16:34:00 +0200 (CEST)
X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from lists.maptools.org (ks365428.kimsufi.com [94.23.4.142])
	by mx-k.one.com (Postfix) with ESMTP id 1DBE1225C03
	for <info@awaresystems.be>; Wed,  1 May 2013 14:33:59 +0000 (UTC)
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id C8F2635C03E;
	Wed,  1 May 2013 09:33:20 -0500 (EST)
Received: from blade.simplesystems.org (blade.simplesystems.org [65.66.246.74])
	by lists.maptools.org (Postfix) with ESMTPS id 2CBF635C03E
	for <tiff@lists.maptools.org>; Wed,  1 May 2013 09:32:18 -0500 (EST)
Received: from freddy.simplesystems.org (freddy.simplesystems.org
	[65.66.246.65])
	by blade.simplesystems.org (8.14.4+Sun/8.14.4) with ESMTP id
	r41EWFWa028849; Wed, 1 May 2013 09:32:15 -0500 (CDT)
Date: Wed, 1 May 2013 09:32:15 -0500 (CDT)
From: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
X-X-Sender: bfriesen@freddy.simplesystems.org
To: David Binderman <dcb314@hotmail.com>
In-Reply-To: <DUB118-W131D26A6F4D697D4CC9FFE9CBC0@phx.gbl>
Message-ID: <alpine.GSO.2.01.1305010923580.2267@freddy.simplesystems.org>
References: <DUB118-W131D26A6F4D697D4CC9FFE9CBC0@phx.gbl>
User-Agent: Alpine 2.01 (GSO 1266 2009-07-14)
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
	(blade.simplesystems.org [65.66.246.90]);
	Wed, 01 May 2013 09:32:15 -0500 (CDT)
Cc: "tiff@lists.maptools.org" <tiff@lists.maptools.org>
Subject: Re: [Tiff] libtiff-4.0.3 bug report
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

On Wed, 1 May 2013, David Binderman wrote:

> Hello there,
>
> I just ran the static analyser "cppcheck" over the source code
> of libtiff-4.0.3. It said
>
> [iptcutil.c:224]: (warning) Storing getc() return value in char variable and then comparing with EOF

I opened the source file to take a look at this issue and immediately 
see the problem but then I see perhaps ten more types of problems that 
"cppcheck" did not warn about and are equally (and sometimes perhaps 
more) evil.

This is contributed old source code to serve as a useful example of 
parsing a format which was deprecated over 12 years ago (but is still 
in active use).

What would you like us to do?

Bob
-- 
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
