Received: from mailgate004.isp.belgacom.be (mailgate004.isp.belgacom.be [195.238.6.89])
	by maildelivery006.isp.belgacom.be (Postfix) with ESMTP id 9EA9B340009
	for <joris.at.lebbeke@skynet.be>; Fri,  5 Oct 2007 18:58:02 +0200 (CEST)
Received: from r153.dmsolutions.ca (HELO duke.maptools.org) ([209.217.116.153])
  by in.mx.skynet.be with ESMTP; 05 Oct 2007 18:58:02 +0200
Received: from duke.maptools.org (duke.maptools.org [127.0.0.1])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id l95Gg04G020450;
	Fri, 5 Oct 2007 12:42:42 -0400
Received: from rune.pobox.com (rune.pobox.com [208.210.124.79])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id l95GfwYk020443
	for <tiff@lists.maptools.org>; Fri, 5 Oct 2007 12:41:58 -0400
Received: from rune (localhost [127.0.0.1])
	by rune.pobox.com (Postfix) with ESMTP id D987513E193;
	Fri,  5 Oct 2007 12:42:18 -0400 (EDT)
Received: from [192.168.2.3] (dpc674728121.direcpc.com [67.47.28.121])
	by rune.sasl.smtp.pobox.com (Postfix) with ESMTP id 0DC8D14241C;
	Fri,  5 Oct 2007 12:42:05 -0400 (EDT)
Message-ID: <47066A49.3000607@pobox.com>
Date: Fri, 05 Oct 2007 12:46:01 -0400
From: Frank Warmerdam <warmerdam@pobox.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20070104)
MIME-Version: 1.0
To: Richard Nolde <nrichard8@qwest.net>
Subject: Re: [Tiff] Color issues in Tiff2pdf
References: <200710050552.l955qN1B009642@duke.maptools.org>
	<47064C84.60909@qwest.net>
In-Reply-To: <47064C84.60909@qwest.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: tiff@lists.maptools.org
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-UIDL: 000000000023ceae.0000282b
X-MSP-STORE: Fri, 05 Oct 2007 18:58:02 +0200
Status: RO

Richard Nolde wrote:
> Regarding color issues with tiff2pdf, the following may or may not be 
> related but it is a bug that could be patched. The line numbers are 
> appropriate for the tiff-3.8.2 version of tiff2pdf.c.  In personal 
> correspondence with the author of the software, Ross Finlayson, he 
> agreed that the assignment for the alpha channel info is incorrect.
> 
> extract from note to Ross:
> 
> "I think there is a typo at line 1486 in the current distribution where 
> it appears that the alpha channel overwrites the blue channel in RGBA 
> images.
> Should the final line have (i * 4) + 3 instead of (i * 4 ) + 2?
> 
>       for(i=0;i<t2p->pdf_palettesize;i++){
>           t2p->pdf_palette[(i*4)]  = (unsigned char) (r[i]>>8);
>           t2p->pdf_palette[(i*4)+1]= (unsigned char) (g[i]>>8);
>           t2p->pdf_palette[(i*4)+2]= (unsigned char) (b[i]>>8);
>           t2p->pdf_palette[(i*4)+2]= (unsigned char) (a[i]>>8);
>       }
> "

Richard,

I have committed this fix in "CVS head" and the 3.9 branch.

It is best to report bugs via the Bugzilla so that they don't get lost.
Reporting them via the list risks having them fall through the cracks, or
using several developers time pursuing them since we don't know the others
are working on it.  (well - more likely just that no one acts on it!)

Best regards,
-- 
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam@pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | President OSGeo, http://osgeo.org

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
