Message-ID: <8a73757f-4c70-0a0b-79a0-7f31231df1ce@darc.de>
Date: Sat, 10 Dec 2022 14:29:00 +0100
From: "Kai Pastor, DG0YT" <dg0yt@darc.de>
References: <dbf671b8-15bc-8e17-d768-a3d1fce0a59b@spatialys.com>
In-Reply-To: <dbf671b8-15bc-8e17-d768-a3d1fce0a59b@spatialys.com>
Subject: Re: [Tiff] [gdal-dev] libtiff v4.5.0 release candidate available
Content-Type: text/plain; charset="utf-8"; Format="flowed"


Thanks for your work!

There is an issue with tiff_vers.h:
The new linebreak style of the TIFF_VERSION_STR definition breaks 
version detection in CMake's FindTIFF.cmake,
leaving TIFF_VERSION unset (in CMake). Some packages rely on this 
variable. E.g. openimageio in vcpkg:

-- Found TIFF
CMake Error at src/cmake/checked_find_package.cmake:154 (if):
  if given arguments:

    "VERSION_LESS" "4.0"

  Unknown arguments specified
Call Stack (most recent call first):
  src/cmake/externalpackages.cmake:90 (checked_find_package)
  CMakeLists.txt:141 (include)


which probably comes from some

if(${TIFF_VERSION} VERSION_LESS "4.0")

I would suggest to restore a formatting which doesn't break existing 
CMake code.

Regards, Kai

Am 09.12.22 um 16:48 schrieb Even Rouault:
> Hi,
>
> I've prepared a release candidate for libtiff v4.5.0:
>
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.gz
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.gz.sig
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.xz
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.tar.xz.sig
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.zip
> - https://download.osgeo.org/libtiff/tiff-4.5.0rc1.zip.sig
>
> Release notes at https://libtiff.gitlab.io/libtiff/releases/v4.5.0.html
>
> I'll promote it to final next week if no serious blocking issues are 
> reported.
>
> Thanks to all contributors.
>
> Best regards,
