Received: from smtp01.UUCP by smtp02.oce.nl (4.1/SMI-4.1)
	id AA11073; Sat, 21 Feb 98 05:10:02 +0100
Received: from sgi.sgi.com (SGI.COM) by smtp01.oce.nl (5.x/SMI-SVR4)
	id AA06871; Sat, 21 Feb 1998 05:08:55 +0100
Received: from cthulhu.engr.sgi.com (cthulhu.engr.sgi.com [192.26.80.2]) by sgi.sgi.com (950413.SGI.8.6.12/970507) via ESMTP id UAA15013; Fri, 20 Feb 1998 20:07:32 -0800
	env-from (owner-tiff@sgi.engr.sgi.com)
Received: (from majordomo-owner@localhost) by cthulhu.engr.sgi.com (950413.SGI.8.6.12/960327.SGI.AUTOCF) id TAA15698 for tiff-list; Fri, 20 Feb 1998 19:24:20 -0800
Received: from sgi.sgi.com (sgi.engr.sgi.com [192.26.80.37]) by cthulhu.engr.sgi.com (950413.SGI.8.6.12/960327.SGI.AUTOCF) via ESMTP id TAA15689 for <tiff-relay@cthulhu.engr.sgi.com>; Fri, 20 Feb 1998 19:24:19 -0800
Received: from pita.cisco.com (pita.cisco.com [171.71.68.13]) by sgi.sgi.com (950413.SGI.8.6.12/970507) via ESMTP id MAA09221
	for <tiff@sgi.com>; Fri, 20 Feb 1998 12:48:35 -0800
	env-from (mruhl@cisco.com)
Received: from corrupt (corrupt.cisco.com [171.71.66.10]) by pita.cisco.com (8.8.5-Cisco.1/8.6.5) with SMTP id MAA21678 for <tiff@sgi.com>; Fri, 20 Feb 1998 12:48:34 -0800 (PST)
Message-Id: <3.0.2.32.19980220124433.0090d8e0@pita.cisco.com>
X-Sender: mruhl@pita.cisco.com
X-Mailer: QUALCOMM Windows Eudora Pro Version 3.0.2 (32)
Date: Fri, 20 Feb 1998 12:44:33 -0800
To: tiff@sgi.com
From: The Sky is ecstasy dancing <smtp01!cisco.com!mruhl>
Subject: fax3 bug?
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: smtp01!fddi-sgi.sgi.com!owner-tiff
Precedence: bulk

Howdy,

I have been working with the the libtiff libary (v3.4) and noticed that the
tif_fax3.c decode stuff (Fax3Decode1D, Fax3Decode2D, Fax3DecodeRLE, and
Fax4decode) return
-1 or 1.

The fax2tiff tool does the call like this:

ok = (*tifin->tif-decoderow)(blah).

Then the return code is check like this:

if (!ok) {
    blah
}

If you return -1 or 1, I don't think that ok will ever be false. :)  All of
the other compression routines return 0 or 1.  So I don't think this is right.

If I am wrong, please let me know.

Thanks,

Mike
-------------------------------------------------------------- 
Michael J. Ruhl                                mruhl@cisco.com 
TGV-Cisco                                         VMS Engineer 
Buckaroo.Banzai@Yoyodyne.com

