Return-Path: <tiff-bounces@lists.maptools.org>
Received: from inas002.isp.belgacom.be (localhost [127.0.0.1])
        by inav016.isp.belgacom.be (8.12.11/8.12.11/Skynet-IN-AV-3.00) with ESMTP id jBE4gulr000573
        for <joris.at.lebbeke@skynet.be>; Wed, 14 Dec 2005 05:42:56 +0100
        (envelope-from <tiff-bounces@lists.maptools.org>)
Received: from inmx012.isp.belgacom.be (inmx012.isp.belgacom.be [195.238.5.90])
        by inas002.isp.belgacom.be (8.12.11/8.12.11/Skynet-IN-AS-2.03) with ESMTP id jBE4ghtk005437
        for <joris.at.lebbeke@skynet.be>; Wed, 14 Dec 2005 05:42:52 +0100
        (envelope-from <tiff-bounces@lists.maptools.org>)
Received: from duke.maptools.org (r153.dmsolutions.ca [209.217.116.153] (may be forged))
        by inmx012.isp.belgacom.be (8.12.11/8.12.11/Skynet-IN-2.32) with ESMTP id jBE4fsN2006171
        for <joris.at.lebbeke@skynet.be>; Wed, 14 Dec 2005 05:41:54 +0100
        (envelope-from <tiff-bounces@lists.maptools.org>)
Received: from duke.maptools.org (duke.maptools.org [127.0.0.1])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id jBE2YqQF031148;
	Tue, 13 Dec 2005 21:35:32 -0500
Received: from mail.srcp.com (mail.srcp.com [12.5.252.28] (may be forged))
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id jBE2YofL031145
	for <tiff@lists.maptools.org>; Tue, 13 Dec 2005 21:34:50 -0500
Received: from CORPDALLMSG05.na.srcp.net ([10.150.10.111] RDNS failed) by
	mail.srcp.com with Microsoft SMTPSVC(6.0.3790.211); 
	Tue, 13 Dec 2005 20:34:46 -0600
X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: RE: [Tiff] Bug in tiffcp (unsupported codecs return 0)
Date: Tue, 13 Dec 2005 20:34:46 -0600
Message-ID: <741E24F735AED141B61948AC155E7DAA04EEB6@CORPDALLMSG05.na.srcp.net>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: [Tiff] Bug in tiffcp (unsupported codecs return 0)
Thread-Index: AcYAP5F0SBuGFBLER+2ahMCF//Y25wAFirSY
From: "Frank, Jason" <JasonFrank@srcp.com>
To: <tiff@lists.maptools.org>
X-OriginalArrivalTime: 14 Dec 2005 02:34:46.0630 (UTC)
	FILETIME=[F2BD0860:01C60056]
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by duke.maptools.org id
	jBE2YofL031145
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-UIDL: 000000000023ceae.00000f8a
X-MSP-STORE: Wed, 14 Dec 2005 05:43:04 +0100
Status:   


As a compromise, perhaps a command line option could be added which turns on 
this behaviour?

-Edward

I'm not really picky either way.  I think that Andrey and I  might have gotten crossed up over the 2 modes of tiffcp though.  If you specify the -a flag, it should append to the existing image.  When I do that with my patch applied, it does not change the existing image, that's exactly what I expect it to do, and I'm quite happy with that.  If you don't specify the -a flag, it uses the last file name to create a new image.  In this case, we've created the file ourselves.  That's the one I'm asking about the unlink on.  I don't think Andrey has a problem with that, but I'll let him speak for himself...

There is another issue with Andrey's patch.  When I tested it out, it didn't fix my problem.  All of his changes appear to be to the readFunc's.  The patch I submitted was to oe of the cpFunc's.  The test image that I'm using is being handled by the cpDecodedStrips function, which is a cpFunc.  So, once I overwrote my change with Andrey's, it stopped working.

Luckily, I don't think this is that bad of a change.  I think that all we need to do is to make the same change to cpFuncs that we made to the readFuncs.  And, since we're here, do we need to do the same to the writeFuncs (or at least review them?)

Jason


_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
