Return-Path: <tiff-bounces@lists.maptools.org>
X-Original-To: info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx-i.b-one.net (mx-i.one.com [91.198.169.56])
	by mail9.b-one.net (Postfix) with ESMTP id 13369400107
	for <info@awaresystems.be>; Mon, 28 Jun 2010 15:26:25 +0200 (CEST)
Received: by mx-i.b-one.net (Postfix, from userid 106)
	id 04C56141445; Mon, 28 Jun 2010 15:26:24 +0200 (CEST)
X-Virus-Scanned: by one.com
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4
Received: from lists.maptools.org (lists.maptools.org [65.39.174.144]) by
 mx-i.b-one.net (Postfix) with ESMTP id F1806141443 for
 <info@awaresystems.be>; Mon, 28 Jun 2010 15:26:23 +0200 (CEST)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by
 lists.maptools.org (Postfix) with ESMTP id BAD111D184BE2; Mon, 28 Jun 2010
 08:25:36 -0500 (EST)
Received: from mail.sidefx.com (mail.sidefx.com [38.99.137.163]) by
 lists.maptools.org (Postfix) with ESMTP id D6C1B1D0E5298 for
 <tiff@lists.maptools.org>; Mon, 28 Jun 2010 08:25:21 -0500 (EST)
Message-ID: <4C28A2B8.4010302@sidefx.com>
Date: Mon, 28 Jun 2010 09:25:12 -0400
From: Edward Lam <edward@sidefx.com>
User-Agent: Thunderbird 2.0.0.24 (Windows/20100228)
MIME-Version: 1.0
To: Adam Goode <adam@spicenitz.org>
References: <4C1A41A5.4070409@spicenitz.org> <4C1A4B72.2020705@sidefx.com>
 <4C1A4F92.2090902@spicenitz.org> <4C1A9C73.1020605@sidefx.com>
 <4C1ABA44.5030704@spicenitz.org> <4C1B7844.9060103@sidefx.com>
 <4C1BB0E6.5060101@spicenitz.org>
 <alpine.GSO.2.01.1006181319120.12887@freddy.simplesystems.org>
 <4C1BBC6B.5050605@spicenitz.org>
In-Reply-To: <4C1BBC6B.5050605@spicenitz.org>
Cc: Tiff List <tiff@lists.maptools.org>
Subject: Re: [Tiff] [PATCH] Build tif_win32.c on Windows except on Cygwin
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
 <mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
 <mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

Seeing that there has been no movement on this in a week, Adam could you 
submit this patch into the libtiff bug database? Just don't want this to 
get lost.

Thanks,
-Edward

Adam Goode wrote:
> On 06/18/2010 02:21 PM, Bob Friesenhahn wrote:
>> On Fri, 18 Jun 2010, Adam Goode wrote:
>>>> That would be a nice patch.
>>> Here's a patch, can someone apply it?
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 954a0c5..2d8743b 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -147,6 +147,18 @@ AC_TYPE_SIZE_T
>>> AC_HEADER_TIME
>>> AC_STRUCT_TM
>>>
>>> +dnl Check for Win32 IO: make sure we have windows.h but not cygwin
>>> +case "${host_os}" in
>>> +    cygwin*)
>>> +        win32_io_ok=no
>> This bit seems wrong in the case where Cygwin is used to build a native
>> Windows (MinGW) application.  It is also wrong for a MinGW
>> cross-compiler.  The target OS should be what matters.
>>
> 
> Also, there is another spot, just above in configure.ac that should be
> target_os, yes?
> 
> dnl We don't need to add math library to all targets
> case "${host_os}" in
>     cygwin* | mingw32* | beos* | darwin*)
>         ;;
>     *)
>         AC_CHECK_LIB(m,sin,,,)
>         ;;
> esac
> 
> 
> 
> Adam
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Tiff mailing list: Tiff@lists.maptools.org
> http://lists.maptools.org/mailman/listinfo/tiff
> http://www.remotesensing.org/libtiff/

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
