Return-Path: <awaresystems.be+caf_=filtered=awaresystems.be@gmail.com>
Delivered-To: filtered@awaresystems.be
Received: from mx2.pub.mailpod2-cph3.one.com ([10.27.25.12])
	by mailstorage18.cst.mailpod2-cph3.one.com (Dovecot) with LMTP id O97xDgr+H1r0/QEAQS8vrQ
	for <filtered@awaresystems.be>; Thu, 30 Nov 2017 14:04:42 +0000
X-HalOne-ID: 688c3a5b-d5d7-11e7-aafe-e0d84895704e
Received: from mail-ot0-f181.google.com (unknown [74.125.82.181])
	by mx2.pub.mailpod2-cph3.one.com (Halon) with ESMTPS
	id 688c3a5b-d5d7-11e7-aafe-e0d84895704e;
	Thu, 30 Nov 2017 14:04:41 +0000 (UTC)
Received: by mail-ot0-f181.google.com with SMTP id i1so6150258oth.9
        for <filtered@awaresystems.be>; Thu, 30 Nov 2017 06:04:41 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-original-authentication-results:x-gm-message-state:delivered-to
         :mime-version:date:from:to:in-reply-to:references:message-id
         :user-agent:cc:subject:precedence:list-id:list-unsubscribe
         :list-archive:list-post:list-help:list-subscribe
         :content-transfer-encoding:sender:errors-to;
        bh=MVmFjveQgcKNNStfvAoU1rn9w93pqNO9nhrkyp9fFAE=;
        b=MRFko+wGdTVU6BV3dhR8brqvA1vtKKlzyvsUfpetYPyGj1w4EGnMQisaImcBA/0oTY
         ix6ctLL5NBwcOKCUN1c+Tr2I3LYnWgv451wqLnO9YKvXcK63ew3fQVdO3I9nkdgXQkta
         nx+slIemlcOkbOMilEuEeIjcvvsw5u2C3r8F3tHP9RjbniDM81aMGBy4VEN9GwK1Dtbw
         TzsE6bC0k2wXhlHb3awbnRMuidQCOhjxQFqd5IVyJjIAeu5+Pjll6+EKFX07/AH2preK
         D6FuZuYGAuDFZYeTs7c/FcgwrfhRd/oJ38Hey+YbsYDcPwaw58jlJHWhJ1ZxWSP9MQpt
         x3Mg==
X-Original-Authentication-Results: mx.google.com;       spf=neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mailfrom=tiff-bounces@lists.maptools.org
X-Gm-Message-State: AJaThX6m8UuqYSNMc7FIEEDS/sxJQU0viaif/FmoJlDnxbzaWdbcc3z2
	s7vppgJH2aeiJs+HAaLXSAsP2l61QrJ84rz8HXiiUUO7HckhaT8=
X-Received: by 10.157.66.216 with SMTP id c24mr5433495otj.332.1512050680161;
        Thu, 30 Nov 2017 06:04:40 -0800 (PST)
X-Forwarded-To: filtered@awaresystems.be
X-Forwarded-For: awaresystems.be@gmail.com filtered@awaresystems.be
Delivered-To: awaresystems.be@gmail.com
Received: by 10.202.194.195 with SMTP id s186csp21708oif;
        Thu, 30 Nov 2017 06:04:38 -0800 (PST)
X-Google-Smtp-Source: AGs4zMYBIn6Z+yaxuyhdTATiv5uZnegPcWXeanNjG7s6qWYL2pQcd3mUzKIbbbGgofxitilMP4jP
X-Received: by 10.28.220.215 with SMTP id t206mr668027wmg.75.1512050678678;
        Thu, 30 Nov 2017 06:04:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1512050678; cv=none;
        d=google.com; s=arc-20160816;
        b=AmIPzy4yCA+bPInQV4RyID2rwhu8bSqMzTztboVCYQ4c4dmwaC2eBrUFH7YJ54VtoF
         FWk7cP7pUOsf4EufL4UyWyMRAo8LQcYnC3v80Fd7XfMfVybKdX60R+MMbYRCExcs6QXN
         sj/HUQXImRyaKeYNUcHr+EvRUM/ikxbvLAZmAOAm8BZBJ/JAwboqA2g1dMQmbOSkvg5D
         ufntc9bRV+0F3hX+4Q7cOJhJQA1HPY7mgPgkyasYPFsx5fZGUROomwQwavoPeBX1ySvR
         hW7XLRgNyI5LdDs2Ug/+7HUxs2L4q2V6jwSRr3cSYBrAqcT6zSJAqxxTSDwM+HVswPCK
         r+eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help
         :list-post:list-archive:list-unsubscribe:list-id:precedence:subject
         :cc:user-agent:message-id:references:in-reply-to:to:from:date
         :mime-version:arc-authentication-results;
        bh=MVmFjveQgcKNNStfvAoU1rn9w93pqNO9nhrkyp9fFAE=;
        b=c5ffRXsvoAWKNBQZeR3lYNGy9CgYiFW14MQPLgLQB1VtJRa4XYt1kBnGWzpBpo0HtU
         do+qo64/15AE8aLrXG3/tH1cUWU3++6Hjpq5Kfw/RJjTJRGSTBYcOxU53K/A5hxQzDr3
         uDhqb2/WXrQdkB9KamceR0Uf7O2DYOdUINEEhE+P+GebYY++e3JX3cbWYByygEd4m8YP
         t/Tw4JunrvJwAuIcmzetJU4l9s8hee5AciEYoB2F0pHrm/Hav3l2sMcTeaBRM2ovWb1r
         kydyVoMIc+buPw8IgYP3dny3qw3uAKYkuJhXubPAWpm9MwuvqfAQk1Y6Tqg52N1vZbcy
         sggw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mailfrom=tiff-bounces@lists.maptools.org
Return-Path: <tiff-bounces@lists.maptools.org>
Received: from lists.maptools.org (ks365428.kimsufi.com. [94.23.4.142])
        by mx.google.com with ESMTP id d16si3418887wrb.312.2017.11.30.06.04.28;
        Thu, 30 Nov 2017 06:04:38 -0800 (PST)
Received-SPF: neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) client-ip=94.23.4.142;
Authentication-Results: mx.google.com;
       spf=neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mailfrom=tiff-bounces@lists.maptools.org
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id A866835C04A;
	Thu, 30 Nov 2017 09:03:27 -0500 (EST)
Received: from b-painless.mh.aa.net.uk (b-painless.mh.aa.net.uk [81.187.30.52])
	by lists.maptools.org (Postfix) with ESMTPS id 8F3A735C048
	for <tiff@lists.maptools.org>; Thu, 30 Nov 2017 09:00:38 -0500 (EST)
Received: from a-webmail.mh.aa.net.uk ([2001:8b0:0:30::75]
	helo=webmail.aa.net.uk) by b-painless.mh.aa.net.uk with esmtpsa
	(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89)
	(envelope-from <rleigh@codelibre.net>)
	id 1eKPOI-0006rr-Cd; Thu, 30 Nov 2017 14:00:38 +0000
Received: from [134.36.162.151] by webmail.aa.net.uk
	with HTTP (HTTP/1.1 POST); Thu, 30 Nov 2017 14:00:37 +0000
MIME-Version: 1.0
Date: Thu, 30 Nov 2017 14:00:37 +0000
From: rleigh@codelibre.net
To: Olivier Paquet <olivier.paquet@gmail.com>
In-Reply-To: <CAAcuQea=YwDxVmHDJzQyAj0FS5etXCvVVUhv3y9b98NV5zxx2A@mail.gmail.com>
References: <mailman.1.1511370003.2203.tiff@lists.maptools.org>
	<alpine.GSO.2.20.1711221748260.22571@freddy.simplesystems.org>
	<5733267.amVCyrLL9T@even-i700> <1940330.HgWqj8TcfN@even-i700>
	<fffa2011-e20e-a29e-ccaf-995ec3846347@codelibre.net>
	<CAAcuQea=YwDxVmHDJzQyAj0FS5etXCvVVUhv3y9b98NV5zxx2A@mail.gmail.com>
Message-ID: <be2bde8649448a0410c6d485b7a6cfdd@codelibre.net>
X-Sender: rleigh@codelibre.net
User-Agent: Roundcube Webmail/1.2.3
Cc: TIFF mailing list <tiff@lists.maptools.org>
Subject: Re: [Tiff] Switching to gitlab ?
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

On 2017-11-30 13:22, Olivier Paquet wrote:
> 2017-11-30 5:31 GMT-05:00 Roger Leigh <rleigh@codelibre.net>:
>> For gitlab, while it's possible to use in the same style as CVS 
>> (direct
>> push to the master branch), it's also possible to prevent direct 
>> pushes
>> and require all changes to go via a merge request.  The workflow is
>> entirely up to what you prefer.  The merge request workflow has the
>> benefit of running continuous integration builds and tests, so you can
>> validate the change before merging it into master.  It's also
> 
> Do we have that setup? I see a merge request from you on that topic. I
> have zero familiarity with that system but it looks like it sets up
> automatic build on merge requests. Is that about it? If I'm reading
> the script correctly, it also runs the tests through the autoconf
> build, right?

Yes, it should all be set up and ready to go!  I opened that merge 
request to test it out, and it all seems to be working.  This is 
building on Unix with autoconf, and cmake, and on Windows with cmake 
(MSVC, Cygwin, MinGW) for a variety of configurations.  This should 
cover all the common cases and give high confidence that there are no 
regressions.  The full set of testcases is run in all cases.

If we're OK with proceeding with the switch, if anyone wanted to take a 
look at https://gitlab.com/libtiff/libtiff/merge_requests/1 and hit the 
"Merge" button if happy, that should test the remainder of the workflow: 
you should see it kick off a build of the master branch once done, which 
should also pass and turn green.

While this is in place and ready to use, it's not at all enforced at the 
moment.  If it's considered acceptable for safety, we can disable direct 
pushes.  If you have access to the project, you can push directly.  I 
think the classification of the different project roles comes into play 
here, e.g. giving you push rights, the ability to merge open merge 
requests etc.

> Another benefit of going through merge resquests is that it's a good
> spot for code review and comments. It's always a good thing have two
> sets of eyeballs go over the code before it gets permanently
> integrated. Although given how little time we sometimes have to put on
> the project, I'm not sure we can manage to always do them in a
> reasonable time frame.

Given the size of the project, it's likely fine to merge your own merge 
requests if there isn't anyone to review it in a timely manner.  It 
should be possible to subscribe to be notified of new merge requests 
though, or even have it post to the list.

> Unless someone objects, I would like to change the README to mention
> the new gitlab home, given that both gitlab and github show that file
> as a home page for a project. It would be a start in getting it to at
> least show up in a web search for libtiff.

Sounds good to me.  If you wanted to give the gitlab workflow a try out, 
you could open it as a merge request!  It would also test that the 
appveyor and gitlab CI test runners work in a forked project (I'm not 
sure mine counts since I set up the runners on the main instance).

By the way, if you were to rename it to README.md, gitlab will render 
the markdown on the main libtiff project page which will allow you to 
use hyperlinks rather than raw URLs, and have it look nicer as well: you 
can use section headers, verbatim text blocks etc.

Another thing to consider is that gitlab also provides 
libtiff.github.io/libtiff as hosted web space for the project; the HTML 
docs etc. could be put there if you wanted.  I haven't yet tried this 
out but setup instructions are on 
https://about.gitlab.com/2016/04/07/gitlab-pages-setup/


Regards,
Roger
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
