Return-Path: <tiff-bounces@lists.maptools.org>
X-Original-To: info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx-q.b-one.net (mx-q.one.com [91.198.169.248])
	by mail9.b-one.net (Postfix) with ESMTP id B83AF40024F
	for <info@awaresystems.be>; Fri, 18 Jun 2010 15:45:10 +0200 (CEST)
Received: by mx-q.b-one.net (Postfix, from userid 106)
	id B0F511D87D6D; Fri, 18 Jun 2010 15:45:10 +0200 (CEST)
X-Virus-Scanned: by one.com
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4
Received: from lists.maptools.org (lists.maptools.org [65.39.174.144]) by
 mx-q.b-one.net (Postfix) with ESMTP id CE1E51D87D6D for
 <info@awaresystems.be>; Fri, 18 Jun 2010 15:45:09 +0200 (CEST)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by
 lists.maptools.org (Postfix) with ESMTP id 116A91D1AEDF1; Fri, 18 Jun 2010
 08:43:42 -0500 (EST)
Received: from mail.sidefx.com (mail.sidefx.com [38.99.137.163]) by
 lists.maptools.org (Postfix) with ESMTP id 14C041D3357C1 for
 <tiff@lists.maptools.org>; Fri, 18 Jun 2010 08:18:15 -0500 (EST)
Message-ID: <4C1B7208.3040802@sidefx.com>
Date: Fri, 18 Jun 2010 09:18:00 -0400
From: Edward Lam <edward@sidefx.com>
User-Agent: Thunderbird 2.0.0.24 (Windows/20100228)
MIME-Version: 1.0
To: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
References: <4C1A9D5B.3000908@sidefx.com>
 <alpine.GSO.2.01.1006172137570.12887@freddy.simplesystems.org>
In-Reply-To: <alpine.GSO.2.01.1006172137570.12887@freddy.simplesystems.org>
Cc: Tiff List <tiff@lists.maptools.org>
Subject: Re: [Tiff] libtiff 4.0 compiler warning on x64 in tif_read.c
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
 <mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
 <mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

Bob Friesenhahn wrote:
> On Thu, 17 Jun 2010, Edward Lam wrote:
> 
>> tif_read.c(207) : warning C4244: '=' : conversion from 'tmsize_t' to
>> 'int', possible loss of data
>
> Please submit a well-tested patch via libtiff Bugzilla.

Except, that this is really recent code and I was hoping that the author 
of said code could give some indication of what was intended here. I 
just ran a cvs annotate and it looks like Frank added this with revision 
1.31 just over 2 months ago. I've added Frank to the CC list.

I could go and just do blind type changes from int to tmsize_t until the 
compiler is satisfied but that's just a losing battle if we keep adding 
new code that has such warnings. Is there some gcc flag we can add to 
make it NOT compile such code?

Incidentally, what do we do for Windows? When new code is committed into 
libtiff, how do we even know that it builds under Windows? We can 
certainly make it so that at least the Windows compiler treats these 
warnings as errors.

-Edward

PS. The ChangeLog is wrong with the "CHUNK_STRIP_READ_SUPPORT" macro. It 
should read "CHUNKY_STRIP_READ_SUPPORT" (note the extra Y) instead.

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
