Return-Path: <tiff-bounces@lists.maptools.org>
X-Original-To: info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx-h.b-one.net (mx-h.one.com [91.198.169.55])
	by mail9.b-one.net (Postfix) with ESMTP id B9DC0400164
	for <info@awaresystems.be>; Fri,  6 Nov 2009 18:01:26 +0100 (CET)
X-Virus-Scanned: by one.com
X-Spam-Score: 4.199
X-Spam-Level: ****
X-Spam-Status: No, score=4.199 tagged_above=0 required=6
	tests=[FORGED_MUA_OUTLOOK=4.199]
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4
Received: from lists.maptools.org (lists.maptools.org [65.39.174.144])
	by mx-h.b-one.net (Postfix) with ESMTP id 7E60E5F7
	for <info@awaresystems.be>; Fri,  6 Nov 2009 18:01:24 +0100 (CET)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id 1AE0D1D22E07B;
	Fri,  6 Nov 2009 12:00:30 -0500 (EST)
Received: from csmtp1.one.com (csmtp1.one.com [195.47.247.21])
	by lists.maptools.org (Postfix) with ESMTP id 3574D1D22E07B
	for <tiff@lists.maptools.org>; Fri,  6 Nov 2009 11:29:38 -0500 (EST)
Received: from awarec74cb3e1c (78-22-2-182.access.telenet.be [78.22.2.182])
	by csmtp1.one.com (Postfix) with ESMTP id D20E51BC01E77;
	Fri,  6 Nov 2009 16:29:37 +0000 (UTC)
Message-ID: <6EA794FD7AFE449A865EB56DFB0DF5F2@awarec74cb3e1c>
From: "Joris Van Damme \(AWare Systems\)" <info@awaresystems.be>
To: "Lee Howard" <faxguy@howardsilvan.com>
References: <4AF3ABD4.4090601@howardsilvan.com><B2F6705BA9D94C61B704586AFD258681@awarec74cb3e1c>
	<4AF43DB4.3080203@howardsilvan.com>
Date: Fri, 6 Nov 2009 17:29:39 +0100
MIME-Version: 1.0
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5843
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579
Cc: TIFF mailing list <tiff@lists.maptools.org>
Subject: Re: [Tiff] TIFFDirEntry type moved from tiff.h to tiffiop.h in v4.0
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

Lee,

> HylaFAX is only using it in one source file:  hfaxd/FileTransfer.c++.
>
> http://hylafax.cvs.sourceforge.net/viewvc/*checkout*/hylafax/hylafax/hfaxd/FileTransfer.c%2B%2B
>
> You'll see that it's used in several places.

From a quick skim through the code, am I correct in assuming this code 
assembles memory structures to pass to LibTiff as file input, so as to 
persuade LibTiff in decoding compressed data that comes from other places? 
Sort-off like wrapping dog medicine in a piece of steak so as to persuade 
the beast to eat it.

If so, yes, that would be a place where the old TIFFDirEntry structure had a 
good purpose. Or maybe not, since structures depend on compiler packing and 
padding settings, and should actually not be used to encode fixed bit/byte 
patterns in a future-proof and portable way, I guess.

The easiest way out would probably be to completely ignore that last issue, 
and define a new, local OldClassTiffDirEntry structure that is completely 
identical to the old TIFFDirEntry of the old ClassicTIFF-only LibTiff, as 
you're never going to hit the ClassicTIFF 4 gigabyte boundary in this 
particular application. Next, do a search&replace on this code file. That 
should fix it.

That would be a FileTransfer.c local fix, rather then a fix inside LibTiff, 
but I do feel that is probably most appropriate here.


Best regards,

Joris

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
