X-Account-Key: account1
X-UIDL: 38e1fa53e7f4aeb6918285c50654335f
X-Mozilla-Status: 0011
X-Mozilla-Status2: 00000000
X-Mozilla-Keys:                                                                                 
Received: from lists.maptools.org (lothlorien.howardsilvan.com [127.0.0.1])
	by mail.howardsilvan.com (Postfix) with ESMTPS id 6D87E67218B
	for <faxguy@howardsilvan.com>; Thu, 13 Aug 2015 15:54:47 -0700 (PDT)
Received: from lists.maptools.org ([94.23.4.142] helo=lists.maptools.org)
	by lothlorien.howardsilvan.com
	with SMTP (2.3.3); 13 Aug 2015	15:54:46 -0800
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id B3BDD35C032;
	Thu, 13 Aug 2015 17:54:10 -0500 (EST)
Received: from auth.a.painless.aa.net.uk (auth.a.painless.aa.net.uk	[90.155.4.51])
	by lists.maptools.org (Postfix) with ESMTPS id 7B79F35C030
	for <tiff@lists.maptools.org>; Thu, 13 Aug 2015 17:54:03 -0500 (EST)
Received: from	d.1.8.9.4.c.9.3.c.6.9.b.2.0.1.c.d.b.d.d.0.6.8.0.0.b.8.0.1.0.0.2.ip6.arpa	([2001:8b0:860:ddbd:c102:b96c:39c4:981d])
	by a.painless.aa.net.uk
	with esmtpsa (TLSv1:AES128-SHA:128)	(Exim 4.77) (envelope-from <rleigh@codelibre.net>)
	id 1ZQ1O7-0006XD-Fa	for tiff@lists.maptools.org;
	Thu, 13 Aug 2015 23:54:21 +0100
To: tiff@lists.maptools.org
References: <55CCE8E5.7060405@codelibre.net>
From: Roger Leigh <rleigh@codelibre.net>
Message-ID: <55CD2017.7060501@codelibre.net>
Date: Thu, 13 Aug 2015 22:54:15 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <55CCE8E5.7060405@codelibre.net>
Subject: Re: [Tiff] [patch] Additional CMake fixes (2)
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-Assp-ID: lothlorien.howardsilvan.com m1-06487-11933
X-Assp-Session: 7FE0858DD428 (mail 1)
X-Assp-Detected-RIP: 2001:8b0:860:ddbd:c102:b96c:39c4:981d, 90.155.4.51
X-Assp-Source-IP: 2001:8b0:860:ddbd:c102:b96c:39c4:981d
X-Assp-Envelope-From: tiff-bounces@lists.maptools.org
X-Assp-Intended-For: faxguy@howardsilvan.com
X-Assp-Version: 2.3.3(14029) on lothlorien.howardsilvan.com
X-Assp-Server-TLS: yes
X-Assp-Delay: not delayed (whitelisted); 13 Aug 2015 15:54:47 -0800
X-Assp-Whitelisted: Yes (whitelistdb)
Return-Path: tiff-bounces@lists.maptools.org
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On 13/08/2015 18:58, Roger Leigh wrote:
> Hi,
>
> I found that there's a copy-paste error in libtiff/CMakeLists.txt.  The
> libtiffxx logic was actually applying properties to the libtiff target,
> which includes its linker map file and this meant that the libtiff
> symbols were not versioned correctly and the libtiffxx symbol versioning
> was absent entirely.
>
> The attached patch sets the properties on the targets correctly, and so
> the symbol versioning should match the autotools logic now.
>
> I have been using the cmake build logic against 4.0.4 for a few months
> now on Linux, MacOS X, FreeBSD and Windows with several Visual Studio
> versions, and it seems to be working well.  On Windows, I now have daily
> integration testing against VS 2012 and 2013, with 2010/2015 to come.
>
> We have a reasonably large set of build slaves in the
> ci.openmicroscopy.org Jenkins CI setup; I could likely set up a libtiff
> build/test job to build the current CVS against all the Visual Studio
> versions if that would be of any benefit to you.  Likewise for
> Linux/MacOSX/BSD, though I suspect these already have much better test
> coverage!  If you wanted to drop the set of project files for each
> Visual Studio version in favour of CMake, this would give you test
> coverage of the complete set.

Just set up for our own internal use and as an example of what's possible:

   https://ci.openmicroscopy.org/job/TIFF-HEAD/

This builds the libtiff CVS HEAD with the following configuration 
combinations:

Visual Studio Version: 11, 12 and 14 (VS2012, 2013 and 2015)
Build Type:            Release and Debug
Architecture:          x86 and x64
Build System:          MSBuild and Ninja

It doesn't build against any third-party libraries such as zlib or 
libjpeg, but they can be downloaded and built as well.


Regards,
Roger
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/


