Message-ID: 396BF8F8.40CBE39C@serendipity-software.com.au
To: tiff@olympiakos.com
Subject: Re: libtiff crash with G4 file
From: peters <peters@serendipity-software.com.au>
Date: Wed, 12 Jul 2000 14:50:00 +1000
Organization: Serendipity Software Pty Ltd
References: <396405C0.35777275@serendipity-software.com.au>
Sender: owner-tiff@olympiakos.com


I have resolved the problem. It was the old uint16 versus uint32 problem.
This stuff seems to have been forgotten when the changes from shorts to longs
happened for the runs arrays. The diff before is for the file tif_fax3.c against
version 3.5.5


174c174
<               sp->refruns[0] = (uint16) sp->b.rowpixels;
---
>               sp->refruns[0] = (uint32) sp->b.rowpixels;
377c377
<               run = runs[0] = (uint16) (lastx - x);
---
>               run = runs[0] = (uint32) (lastx - x);


Can someone apply this to the CVS tree so it appears in the next version?

Thanks,

-- 
Peter Skarpetis
Serendipity Software Pty Ltd
67 Fitzroy Street
Surry Hills NSW 2010
Sydney Australia

Phone: +612 93321788     
Fax:   +612 93321766
email: peters@serendipity-software.com.au
WWW:   http://www.riponce.com

peters wrote:
> 
> I have a G4 file which crashes both libtiff 3.5.4 and 3.5.5.
> I run libtiff through Purify while processing this file and what I got
> was some unitialised memory reads in the macro  EXPAND2D(EOFG4)
> 
> I am not sure what is causing it so I have placed a zipped version of the file
> at ftp://ftp.skarpetis.com/pub/tifflib for anyone who might want to take a look
> 
> Thanks,
> 
> --
> Peter Skarpetis
> Serendipity Software Pty Ltd
> 67 Fitzroy Street
> Surry Hills NSW 2010
> Sydney Australia
> 
> Phone: +612 93321788
> Fax:   +612 93321766
> email: peters@serendipity-software.com.au
> WWW:   http://www.riponce.com

