Return-Path: <awaresystems.be+caf_=filtered=awaresystems.be@gmail.com>
Delivered-To: filtered@awaresystems.be
Received: from mx2.public.one.com ([10.246.18.22])
	by mail6.local.one.com (Dovecot) with LMTP id b0PMHge3LVi1NwEAsyOMew
	for <filtered@awaresystems.be>; Thu, 17 Nov 2016 15:09:40 +0000
X-HalOne-ID: dac4ff57-acd7-11e6-80b0-b82a72d88088
Received: from mail-yb0-f178.google.com (unknown [209.85.213.178])
	by mx2.public.one.com (Halon Mail Gateway) with ESMTPS
	for <filtered@awaresystems.be>; Thu, 17 Nov 2016 15:09:36 +0000 (UTC)
Received: by mail-yb0-f178.google.com with SMTP id a184so58893621ybb.0
        for <filtered@awaresystems.be>; Thu, 17 Nov 2016 07:09:36 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-original-authentication-results:x-gm-message-state:delivered-to
         :date:from:to:in-reply-to:message-id:references:user-agent
         :mime-version:cc:subject:precedence:list-id:list-unsubscribe
         :list-archive:list-post:list-help:list-subscribe
         :content-transfer-encoding:sender:errors-to;
        bh=xNOnc1w1I1kM+F7OQOYfCcI5201P+ogPxZUbpMBpoiA=;
        b=Gc0mDps0ZZy9AD0fjfrjpTbFjqHr2+NVyVVAET85y26cNU7lp1aAYXoPakTIwGEe2L
         Y4vwSLXfMv4z/b/9Wn47qUr8RZYPW9VGAR96R7J359IW5YhszwfIm/1TYYUhS1mXpzn2
         LjtVpuphmtBYrmfYkIVGzPxKfhpj9oTKBUH76f5RNb5OB/eBKrYe9lg7k7h49wtCfImG
         lAR9Ru32tiYGXZRX6u9sLInpXtzyTPfmW/w6/84v17LlXPswHgdxQdXtkU21R9TvDOY5
         Ng2DBIQ1RkuZNtUvf6N+Yup1AEnadVxl+nHrPTM+soEkU3B4Zi+5jlBFzUk30LFWDgzJ
         EbpQ==
X-Original-Authentication-Results: mx.google.com;       spf=neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mailfrom=tiff-bounces@lists.maptools.org
X-Gm-Message-State: AKaTC01t1zcDAsHlOjLapJMaBNW8pjH+T47cOJ+abnigU5WxjyjU2OhkZV6z4hWBtCpwuyk1x7fI+BOHZL3p4JCbnpnHtuk=
X-Received: by 10.157.43.23 with SMTP id o23mr1560330otb.206.1479395374076;
        Thu, 17 Nov 2016 07:09:34 -0800 (PST)
X-Forwarded-To: filtered@awaresystems.be
X-Forwarded-For: awaresystems.be@gmail.com filtered@awaresystems.be
Delivered-To: awaresystems.be@gmail.com
Received: by 10.202.192.135 with SMTP id q129csp328367oif;
        Thu, 17 Nov 2016 07:09:32 -0800 (PST)
X-Received: by 10.28.55.203 with SMTP id e194mr1558296wma.6.1479395372634;
        Thu, 17 Nov 2016 07:09:32 -0800 (PST)
Return-Path: <tiff-bounces@lists.maptools.org>
Received: from lists.maptools.org (ks365428.kimsufi.com. [94.23.4.142])
        by mx.google.com with ESMTP id uf7si3192664wjb.178.2016.11.17.07.09.32;
        Thu, 17 Nov 2016 07:09:32 -0800 (PST)
Received-SPF: neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) client-ip=94.23.4.142;
Authentication-Results: mx.google.com;
       spf=neutral (google.com: 94.23.4.142 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mailfrom=tiff-bounces@lists.maptools.org
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id 8244A35C04F;
	Thu, 17 Nov 2016 10:08:40 -0500 (EST)
Received: from smtp.simplesystems.org (smtp.simplesystems.org [65.66.246.90])
	by lists.maptools.org (Postfix) with ESMTPS id C645335C04D
	for <tiff@lists.maptools.org>; Thu, 17 Nov 2016 09:41:58 -0500 (EST)
Received: from freddy.simplesystems.org (freddy.simplesystems.org
	[65.66.246.65])
	by smtp.simplesystems.org (8.14.4+Sun/8.14.4) with ESMTP id
	uAHEfrVK004340; Thu, 17 Nov 2016 08:41:53 -0600 (CST)
Date: Thu, 17 Nov 2016 08:41:53 -0600 (CST)
From: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
X-X-Sender: bfriesen@freddy.simplesystems.org
To: Aaron Boxer <boxerab@gmail.com>
In-Reply-To: <CAK8GPyDHaGBiSgjL2u07aAjjrMOO3C7ZG9a9=qpPfXeB3srDQg@mail.gmail.com>
Message-ID: <alpine.GSO.2.20.1611170836180.23214@freddy.simplesystems.org>
References: <CAK8GPyDHaGBiSgjL2u07aAjjrMOO3C7ZG9a9=qpPfXeB3srDQg@mail.gmail.com>
User-Agent: Alpine 2.20 (GSO 67 2015-01-07)
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
	(smtp.simplesystems.org [65.66.246.90]);
	Thu, 17 Nov 2016 08:41:54 -0600 (CST)
Cc: TIFF mailing list <tiff@lists.maptools.org>
Subject: Re: [Tiff] Visual Studio Warnings
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

I assume that this was for a 64-bit build.  Most of these warnings 
look suspect to me.  Anything involving computation of a pointer 
address deserves close attention.

Please check if adding (size_t) to the shifted value like

   m = img->UaToAa+((size_t) a2<<8);

makes the warning go away for 32 and 64-bit builds.

The libtiff release is still "pending" but if all goes well I expect 
that it will no longer be pending as of Saturday the 19th.

Bob

On Wed, 16 Nov 2016, Aaron Boxer wrote:

> FYI:
>
> libtiff\tif_win32.c(242): warning C4312: 'type cast': conversion from 'int'
> to 'thandle_t' of greater size
> \libtiff\tif_win32.c(287): warning C4311: 'type cast': pointer truncation
> from 'thandle_t' to 'int'
> \libtiff\tif_win32.c(342): warning C4311: 'type cast': pointer truncation
> from 'thandle_t' to 'int'
> \libtiff\tif_dirinfo.c(724): warning C6031: Return value ignored:
> 'snprintf'.
> \libtiff\tif_getimage.c(1443): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1514): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1645): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
> \libtiff\tif_getimage.c(1711): warning C6297: Arithmetic overflow:  32-bit
> value is shifted, then cast to 64-bit value.  Results might not be an
> expected value.
>
> The first three already have a FIXME comment.
>
> I doubt these cause actual bugs, but always to be warning-free.
>
> Cheers,
> Aaron
>

-- 
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
