Return-Path: <awaresystems.be+caf_=filtered=awaresystems.be@gmail.com>
Delivered-To: filtered@awaresystems.be
Received: from mx-q.one.com (mx-q.one.com [91.198.169.248])
	by mail6.local (Postfix) with ESMTP id 77D1A80150201
	for <filtered@awaresystems.be>; Tue, 18 Dec 2012 19:57:27 +0100 (CET)
X-Virus-Scanned: by one.com
Received-SPF: pass (mx-q: domain of awaresystems.be+caf_=filtered=awaresystems.be@gmail.com designates 209.85.220.180 as permitted sender)
X-Greylist: whitelisted by SQLgrey-1.8.0-rc2
Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180])
	by mx-q.one.com (Postfix) with ESMTP id 1526173C10E
	for <filtered@awaresystems.be>; Tue, 18 Dec 2012 18:57:26 +0000 (UTC)
Received: by mail-vc0-f180.google.com with SMTP id p16so1288649vcq.39
        for <filtered@awaresystems.be>; Tue, 18 Dec 2012 10:57:26 -0800 (PST)
X-Received: by 10.52.18.169 with SMTP id x9mr4145497vdd.41.1355857046119;
        Tue, 18 Dec 2012 10:57:26 -0800 (PST)
X-Forwarded-To: filtered@awaresystems.be
X-Forwarded-For: awaresystems.be@gmail.com filtered@awaresystems.be
Delivered-To: awaresystems.be@gmail.com
Received: by 10.58.144.166 with SMTP id sn6csp195087veb;
        Tue, 18 Dec 2012 10:57:25 -0800 (PST)
X-Received: by 10.52.177.103 with SMTP id cp7mr4050694vdc.113.1355857044226;
        Tue, 18 Dec 2012 10:57:24 -0800 (PST)
Received-SPF: neutral (google.com: 91.198.169.248 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) client-ip=91.198.169.248;
Received: by 10.220.204.81 with POP3 id fl17mf839028vcb.2;
        Tue, 18 Dec 2012 10:57:24 -0800 (PST)
X-Gmail-Fetch-Info: info@awaresystems.be 1 pop.awaresystems.be 110 info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx-q.one.com (mx-q.one.com [91.198.169.248])
	by mail6.local (Postfix) with ESMTP id 1D52480150201
	for <info@awaresystems.be>; Tue, 18 Dec 2012 19:55:50 +0100 (CET)
X-Greylist: from auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from lists.maptools.org (ks365428.kimsufi.com [94.23.4.142])
	by mx-q.one.com (Postfix) with ESMTP id E437873AA39
	for <info@awaresystems.be>; Tue, 18 Dec 2012 18:55:49 +0000 (UTC)
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id 3C22F35C026;
	Tue, 18 Dec 2012 13:54:26 -0500 (EST)
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by lists.maptools.org (Postfix) with ESMTP id D98FD35C026
	for <tiff@lists.maptools.org>; Tue, 18 Dec 2012 13:53:18 -0500 (EST)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.5/8.14.5) with ESMTP id qBIIrHtg012007
	for <tiff@lists.maptools.org>; Tue, 18 Dec 2012 13:53:17 -0500 (EST)
From: Tom Lane <tgl@sss.pgh.pa.us>
To: tiff@lists.maptools.org
Date: Tue, 18 Dec 2012 13:53:17 -0500
Message-ID: <12006.1355856797@sss.pgh.pa.us>
Subject: [Tiff] More problems with libjpeg cross-version differences
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

I'm currently failing to build libtiff 4.0.3 in Fedora rawhide, because
raw_decode fails like this:

FAIL: raw_decode
================

Pixel 0 did not match expected results.
Expect:  18   0  41
   Got:  15   0  18
Pixel 64 did not match expected results.
Expect:   0   0   0
   Got:   0   0   2
Pixel 512 did not match expected results.
Expect:   5  34 196
   Got:   6  36 182
Pixel 0 did not match expected results.
Expect:  18   0  41 255
   Got:  15   0  18 255
Pixel 64 did not match expected results.
Expect:   0   0   0 255
   Got:   0   0   2 255
Pixel 512 did not match expected results.
Expect:   5  34 196 255
   Got:   6  36 182 255

If you look closely, the actual results are those that raw_decode
expects from pre-IJG7 libjpeg versions, but it's thinking it should get
the IJG7 results.  This is probably because Fedora uses libjpeg-turbo
and recently switched over to the libjpeg 8 API --- but evidently,
libjpeg-turbo only adopted the API changes and did not change the
default decompression/upsampling algorithms.

We could try to hack the "#if JPEG_LIB_VERSION >= 70" test to make this
pass in all cases, but I'm thinking that expecting exact pixel values
out of libjpeg is a bad idea from the get-go.  What I'd recommend
instead is allowing a range of acceptable pixel values.

Thoughts?

			regards, tom lane
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
