Return-Path: <tiff-bounces@remotesensing.org>
Received: from inmx009.isp.belgacom.be (inmx009.isp.belgacom.be [195.238.3.146])
        by mailst006.isp.belgacom.be (8.12.11/8.12.11/Skynet-MAILSTORE-2.14) with ESMTP id i820HRkY009423
        for <joris.at.lebbeke@skynet.be>; Thu, 2 Sep 2004 02:17:27 +0200
        (envelope-from <tiff-bounces@remotesensing.org>)
Received: from xserve.flids.com (adsl-065-083-169-202.sip.mco.bellsouth.net [65.83.169.202])
        by inmx009.isp.belgacom.be (8.12.11/8.12.11/Skynet-IN-2.32) with ESMTP id i820H7X6008806
        for <joris.at.lebbeke@skynet.be>; Thu, 2 Sep 2004 02:17:10 +0200
        (envelope-from <tiff-bounces@remotesensing.org>)
Received: from adsl-065-083-169-202.sip.mco.bellsouth.net (localhost [127.0.0.1])
	by xserve.flids.com (Postfix) with ESMTP
	id 409F328EB24; Wed,  1 Sep 2004 20:16:43 -0400 (EDT)
X-Original-To: tiff@remotesensing.org
Delivered-To: tiff@remotesensing.org
Received: from tiki-lounge.com (tiki-lounge.com [199.181.107.26])
	by xserve.flids.com (Postfix) with ESMTP id 8610028EAFE
	for <tiff@remotesensing.org>; Wed,  1 Sep 2004 20:16:29 -0400 (EDT)
Received: from tiki-lounge.com (localhost [127.0.0.1])
	by tiki-lounge.com (8.12.1/8.12.1) with ESMTP id i820C7Te021957;
	Wed, 1 Sep 2004 17:12:08 -0700 (PDT)
Received: from localhost (raf@localhost)
	by tiki-lounge.com (8.12.1/8.12.1/Submit) with ESMTP id i820C6Td021954; 
	Wed, 1 Sep 2004 17:12:07 -0700 (PDT)
Date: Wed, 1 Sep 2004 17:12:06 -0700 (PDT)
From: "Ross A. Finlayson" <raf@tiki-lounge.com>
X-X-Sender: raf@tiki-lounge.com
To: Joris <joris.at.lebbeke@skynet.be>
Subject: Re: [Tiff] Tiff2Pdf bug
In-Reply-To: <000701c4907c$4ffe3220$8d23c850@dfgrrxsknr4e>
Message-ID: <Pine.GSO.4.43.0409011702270.21634-100000@tiki-lounge.com>
X-Ross: Ross
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: tiff@remotesensing.org
X-BeenThere: tiff@remotesensing.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: TIFF and libtiff discussion  <tiff.remotesensing.org>
List-Unsubscribe: <http://xserve.flids.com/mailman/listinfo/tiff>,
	<mailto:tiff-request@remotesensing.org?subject=unsubscribe>
List-Archive: <http://xserve.flids.com/pipermail/tiff>
List-Post: <mailto:tiff@remotesensing.org>
List-Help: <mailto:tiff-request@remotesensing.org?subject=help>
List-Subscribe: <http://xserve.flids.com/mailman/listinfo/tiff>,
	<mailto:tiff-request@remotesensing.org?subject=subscribe>
Sender: tiff-bounces@remotesensing.org
Errors-To: tiff-bounces@remotesensing.org
X-UIDL: 313fdd638007109bb034a0af92661fc3



On Thu, 2 Sep 2004, Joris wrote:

> Ross,
>
> Seems to me that in t2p_read_tiff_init(...), second check for
> t2p->tiff_pages==NULL, near the beginning of the function, should actually be
> checking for t2p->tiff_tiles==NULL.
>
> Also, it might not be an error if _TIFFmemset checks for it, but in t2p_init(),
> top few lines, you might want to move _TIFFmemset(t2p,...) to after the check
> for t2p==NULL.
>
> Joris Van Damme

Hi Joris,

Thank you for your code review.  I have this and some other issues that
are being fixed in the tiff2pdf.c file, as I get them fixed I will send
the patch to Andrey.

Hey I got the "yet another TIFF tag viewer" property sheet shell extension
for Windows working, I need to add the rest of the help and warning/error
functions and then I hope you will try it, hopefully this week.  I'm even
unable to crash the Explorer with it recently.

I found a bug in libtiff, when a floating point is returned for a
SRATIONAL value for printing the value, the two int32's should be treated
as an int32 for the numerator and uint32 for the denominator.

Hey about the palette and some notion of compressing the palette, I
thought one method that was in use was to compress the ColorMap with LZW,
and then when the library gets the ColorMap, if its number of elements
doesn't match the
SamplesPerPixel/PhotometricInterpretation/ExtraSamples/Indexed indicated
correct value for the count of elements of the ColorMap, then it is
uncompressed transparently for the ColorMap access.

Regards,

Ross F.

_______________________________________________
Tiff mailing list
Tiff@remotesensing.org
http://xserve.flids.com/mailman/listinfo/tiff
