Return-Path: <tiff-bounces@lists.osgeo.org>
Received: from mailgate209.isp.belgacom.be ([195.238.22.41])
          by mailfep002.skynet.be
          (InterMail vM.8.04.03.28.4 201-2389-100-182-103-20180124)
          with ESMTP
          id <20210416174611.VNWI7428.mailfep002.skynet.be@mailgate209.isp.belgacom.be>
          for <chris.lindelaan@skynet.be>; Fri, 16 Apr 2021 19:46:11 +0200
Authentication-Results: mx201.skynet.be; dkim=none (message not signed) header.i=none; spf=None smtp.pra=tiff-bounces@lists.osgeo.org; spf=Pass smtp.mailfrom=tiff-bounces@lists.osgeo.org; spf=Pass smtp.helo=postmaster@lists.osgeo.org
Received-SPF: None (mx201.skynet.be: no sender authenticity
  information available from domain of
  tiff-bounces@lists.osgeo.org) identity=pra;
  client-ip=140.211.15.3; receiver=mx201.skynet.be;
  envelope-from="tiff-bounces@lists.osgeo.org";
  x-sender="tiff-bounces@lists.osgeo.org";
  x-conformance=sidf_compatible
Received-SPF: Pass (mx201.skynet.be: domain of
  tiff-bounces@lists.osgeo.org designates 140.211.15.3 as
  permitted sender) identity=mailfrom; client-ip=140.211.15.3;
  receiver=mx201.skynet.be;
  envelope-from="tiff-bounces@lists.osgeo.org";
  x-sender="tiff-bounces@lists.osgeo.org";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:mail.osgeo.org a:lists.osgeo.org
  a:mail.osgeo.osuosl.org a:tracsvn.osgeo.osuosl.org -all"
Received-SPF: Pass (mx201.skynet.be: domain of
  postmaster@lists.osgeo.org designates 140.211.15.3 as
  permitted sender) identity=helo; client-ip=140.211.15.3;
  receiver=mx201.skynet.be;
  envelope-from="tiff-bounces@lists.osgeo.org";
  x-sender="postmaster@lists.osgeo.org";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 mx a:mail.osgeo.org a:lists.osgeo.org
  a:mail.osgeo.osuosl.org a:tracsvn.osgeo.osuosl.org -all"
X-Ironport-Dmarc-Check-Result: validskip
IronPort-SDR: 36KxUOhbrbiV+MA7jiGOUcVlHMgGUtFS+rRaVzaLnD3A6XbggKRS3fesHBBbptndMl/CM8tuPt
 2ClJZLlXncrJEiZHSdnXIF5T9lc1tkW0lzomyFO+Xtmebc5JstX2mQWKnUPpoB3gV3tUUguelM
 RsxoVmQNWH/3arHkTD5twTg3kWPG6mjVGE3WFj8sVGUs+1L8fOQrWEavSwBQrFFo+2+gk5SWg7
 +ID/r82Tab998wj0d6qDcBgwFXIH3tcw+PD346kLQGTv9Sixcf9itOQdD46oRaY71zUrmNIsXO
 sc5660Au4F/uppnbWY7b55p8
X-IPAS-Result: =?us-ascii?q?A0EABgBBzHlghwMP04xaHgEBCxIMQIN2GQFkWAElAwc5j?=
 =?us-ascii?q?UeHLQaLf4U2ZR2LZBcBAQIBAQEBAQkdCwoCBAEBAQIEgQ8BhTAfBgEENBMCA?=
 =?us-ascii?q?wEBAQMCAwEBAQEBAQQBAQECAQECAwICAQECEAEBAYEBBn5CBGIGWwQ1AYERJ?=
 =?us-ascii?q?QwCMQ2COAUCAxgObYEIAQEBAQEBAQEBAQEBAQEBAQEBARYCDVJoAgQBAQUCM?=
 =?us-ascii?q?AwKHg4DAQIEAgIBPwQECAMBFQ4BMAEEEwUGBYJhAYJUAQwmBAEKrTKBNBpnh?=
 =?us-ascii?q?FiCFRmCYAaBOY4YfYEOeBuDYIJgAQSCKoUqBIFUggEsW59sm3OBFAqDDIEhB?=
 =?us-ascii?q?4EphxaHHoRhhyAjlEgDkDShCpJoGUaEK4FrIYFcH2Y7PoIrPw4BAgECDQIBA?=
 =?us-ascii?q?QEDAQIBAgIBAQICAQEBAY5TiE2FRkEBMDgCBgoBAQMJViYTC4oJgWsBAQ?=
IronPort-PHdr: A9a23:8STbARNjjLRK9QBGbZQl6nanBBdPi93PFj5Q0YIujvd0So/mwa6KF
 HLW6fgltlLVR4KTs6sC17OH9fmxBCdfvN6oizMrSNR0TRgLiMEbzUQLIfWuLgnFFsPsdDEwB
 89YVVVorDmROElRH9viNRWJ+iXhpTEdFQ/iOgVrO+/7BpDdj9it1+C15pbffxhEiCCybL9vK
 Bi6txjdu80WjIdtKKs8ygbCr2dVdehR2W5mP0+YkQzm5se38p5j8iBQtOwk+sVdT6j0fLk2Q
 KJBAjg+PG87+MPktR/YTQuS/XQcSXkZkgBJAwfe8h73WIr6vzbguep83CmaOtD2TawxVD+/4
 apnVAPkhSEaPDM/7WrZiNF/jLhDrRyhuRJxzY3ab46SOvpiY63dZdEXS2hcUstfSyBOHoyyY
 JUUD+caIeZVrZPwq0cQoReiGwWhAv7kxD9Shn/x2K03y+otEQTH3AwvAtIBrnDUp8jwNKgMT
 O+61q3IzTXZYP9YxDzw743IfQ48rv6WWbJwcNHRyVU0GgPelFqQsYvlMymN1uQRqmWW6fdrW
 u2zhWA9sQ5xviSvydk2ionPno8Y1lTJ+DhkzYsoOdC1SE51b9G4HJdOsyyXM4t4T8AtTWx0p
 Cs3zrIItJ+7ciQUy5kqxQDSZvOZf4WH4R/tVPqdLDFlj3xrf7K/ggy98UmmyuDkUcm0y1lKo
 TRCktXWsXANzRPT586aQfV+5keswSuD2g/P5u1eP0w4iLfXJ4Q8zrMwjJYev1zPEjHrlEnol
 qObdkUp9vK15+nnbbjqvIGQOoFyhwrjKKohgNa/Dv49MgUWX2iU5+C81Lr78E39QbVKleE2k
 rLDvJDdPsQbqbC2AwhP3oYk8Ra/AC+q0NUenXYZMFJIYA+Lgof1N13UPvz0EOqzj06xnDpr3
 fzLMKXtApDXIXjClLfhc6x960lZyAcr0dBf5pxUCr8YLP3oXU/xqdrYAQMnPAyv2OvnDNR91
 pgCWWKUGKOZN7jSsVCW6eIoOeWMY5UVuDnlJ/g/+/HulWM5mUMafaSxwZQXaGq4HvV9I0mDZ
 Xrsg9EBHnoUsQo6VuPlkluCXCVIZ3axX6M84C80CJ68AYjYWI/+yIGHxzqxS51KenhdWBfLF
 Xbza57CXOwDZSXUJdVu1TkNVLykQolm0gmytQj80P17L+TaqRAero/pgd185unPkkMu9DJ6S
 t6QynyAVH1cmmITWyRw27twrEs7zU2MhrNlif5VHsAG+vVSTw0hPoTdxeEpNtbpRwjhc96FR
 UzzQsm6GSpjCZU1wsQSeAB6ANqviVbExSXtBrYUk7mCAtsz6r7d2H7qYNp8xXiV6a86klMGT
 8JDOHfzg6d+8xTUVZLInUvcjauzaKkHwAbJ9Xyf1iyJp05VV0h3S6qSRm0VZEbdsYHk4FjfR
 aSlE7UtP1h9zpvWNqpEZPXtjE5aX7HkI9vTZCS2gWjmVjiSwbbZJo/rdHgQ2G3YBUQNlwAat
 z7SMAUyDyOguH72FzV2EhT3fxW/oqFFtHqnQxpsnEmxZEp72u/tkjY8mOCcRvUP37kNpCYmr
 XBOEU2g287NY/KFt1A5JeNHYsI77UsB32+K/wB+P5n1KadkixZedglspErh2l1xDZkIisklq
 n4mjUJyJKuU3UkHdmae2pb9afXMMmen2hepZubN303Gls6M8/IT6fo27l/koQeiG1EK93R8z
 8IT1GCT65KMCxAdAtrqSkhizxFhvPnBZzUloYbd1HliK66x5yPD1dxsDuw4zB2tZP9bMbiYD
 0n1CMIXAI6pMuN500OxYEc8NftJvLUxI9vgd/aC3/uzO/18mTu9kWldyIR8yV6XsS1nRePPm
 ZEfzJmw5AaMWjbigVvkifjZ8ahiYjcfViq62XK8XchKZbx0cJpNA2r8a8uwjs5zgZLgQTZR6
 UKjClUa2cSoZQv3DRS13Ate0l4SqGCmni3wxiJ9kjUgpK6SlCLUxOGqeB0CM29NDG5s6DWka
 ZS1gd5fVk+1aQMkjzOh5F3m3O5cv6tyKC/UW0gJNyn6Imd+U7eh46KYap0qittguiFWXeKgJ
 FGCH+eh+11AinqlRjYYn2NzbTyht5TnkgYvjXLHdC81t3nIf8xsgx3St7m+DbZc2CQLQC5gh
 HzZHF+5apO1/Nua0p3Er+a1WnmJUpxIbTKtypiPuSz94ndlS07a/bj7ipj8HA423DWuncVrW
 yuNphHhZILmzIy+MPl7ZQ9vH1Dx7Ix9AI40we5SzNkAnHMdgJuS538Ol2z+ZM5a1azJZ30IX
 TcXwtTR7WDN4kBoI3OXyo68bU2zquNZbsKhKiMTynhltoZRC7aS4aAClyYn6la/qAvQZ7B6k
 FJ/gbMy6XAUxusOpQwmwz61BrEJAVIeOjfjmhPO6Mqx5Klaf2egd7Gs2VE2xIz5Suvb+0cFB
 TCiMp45eE04pt1yKlfNzGH+5sn/dd/cYMhS/hyYnhHcjvREfZc4l/4Eny1iair2uXwozfJ+j
 AQ7hM3i+tLeciM0oeTiUXs6fnXvasge+y/gl/NbjpzOhsa0HYRnFylNVpa7KJDgWD8Uq/njM
 B6DVTMmrXLOU6beEwHa4kB7qXnCCLivNmqLPz8e1tpvQ1+aPkMV02V2FH0q24U0EAyn3pmrb
 EZ36HUb4UP+oRZX4uZpLAXkFGDEqwqvLDAuR9LMSXgephEH7EDTP8uE6+t1FCwN5ZytojuGL
 WmDbhhJB2UECQSUQkruNb606Zzc4vCVU6CgeuDWb+zE+ok8H7+YgIii2Yx883OQO9WTazN8W
 uYj1BMLWGAxEpbckjQLDSsMmC/KKcmBq1+1qCl2tdyktvPwVw/oo4yVBN4weZ1mqRW/gKPFM
 PWfiSE/Li1F0YgIg3jSx/AWjkIIgip1aT/rFq8PuCmLS7nNnbRTSRkBZGs2Pc9MpcoU5ARGN
 M/Fh9+w7YZW5tYNAkxeHRzkipvxPIoRIHC7OU+BDkvZfLiBIDTKxYnwb8beAfVIi/5IshSrp
 TuBO0viJSiY0T7yWB2od+ZWg2mXMQdft4e0bht2QTG/FJS8M0T9aYIx1nU/2thWzjvSOHQZM
 CRgfk8FtbCW4S5Cw71+F2FH8nt5PLyEliKevKHTLpcbt+cuAzwhzr4Cpi5jkv0MsWcfF5kX0
 GPIo9Vjok+riLyK2mA/CVxVqSdNiZ7Nt0gxXMeRvpRGR3vA+woAqGuKDBFf7cdkBNOqsadNz
 NPCj4r3KSxe6JTT5sQRAI7TMs3NYx9DeVL5XSXZCgcIV2vhLWbEm0lUi+2f7FWRr4Mmsd7rg
 5UDTflcTlN/RZZ4Qgx1WdcFJplwRDYtl7WW2dUJ6XSJpx7UXMxGv5rDW6HaEbD1JT2el7UBe
 woQzOayM9EILoOikR8HCBEyjMHQFkHXR9wIviBxclp+vhBW6HYnBmgjk0u3bwqs5DkUDvG5m
 VgxkAQ2aLYp9Szw+BEwPVXHo203ikZU+52tiGKUeT/1aqCrUoxRTS3vqk8qNtX8WQk9ZF+uh
 0VvLynCAbVKgLZnM2dwlQjHvd1IA/EUCKRAZFV47cHSXO0h1BFnkgvixUJD4oPtDZp5iBBsd
 oWjonUG3BhsPoddDZyVH7JAyx1rvozLpjWhvsg1wRQCPAAK62yff2gPokNabtEOF2+T5uVpr
 De6tX5GcWkIWeAtp5pC8kImJ//GyDnv3rkFLVq+ZbX3Eg==
IronPort-HdrOrdr: A9a23:cs6s4KprNdg8yERxhvVUK04aV5u0L9V00zAX/kB9WHVpW+afkN
 2jm+le8BfyhioYVn1Io6H4BICrR3TA+ZlppbQLNbC5UwX8/EeuJodu7YztqgeQbhHW3OhbyK
 tmbuxCGMT9ZGIK//rSzQGkH78bsby62YyynuHE1TNRS2hRGtVdxihjDALzKDwUeCBiBYAlUL
 uR49MvnUvRRV0zbt6nQlkJNtKz2OHjsZL9fFo+AQQ7gTP+/A+Azb7hDlyjwhwFWShOyrtKyx
 m3ryXd5r+/98290APWzWXJ759b8eGRtOdrIOyppowrJi73igCuDb4RPIGqmDwuuumg5BILvb
 D30nMdFv1p53ncc22zqxeF4Xid7B8U53XvyUCVjBLYyKSTLl9XZPZpv45ffxfDgnBQy+1U6r
 5B3G6SqvNsfGj9tRn9/NTBWlVLkUe5sBMZ4JYupkFYOLFuCoN5nMg18E9TLZYNBy6S0vFcLM
 BeSOXV5PNbajqhHhbkl1gq5NStW3A6GVO4TlMZusqTugIm4UxR/g8g+egWnnJF3Jc5TYdJ6t
 7JNallj/VnRNIXa6UVPoY8aPryM1HoSRLIdFmfJVL7GIE/Ukiil7fHpIwJwOmrfdgzwIAsmJ
 7MOWk5iVIP
X-IronPort-Anti-Spam-Filtered: true
X-MGA-submission: =?us-ascii?q?MDEy7SYFB0ncf4h42K8R+vrS+cUSwlNFigLcNY?=
 =?us-ascii?q?GjpvgCARIZDjJFA1w/wHwDAW6gwqSIpbxcIM9S8H0in0rszDsesR1LLV?=
 =?us-ascii?q?3BYN8zmRDOF9se0SKbrzQUY1J13ZWaOHd/eX4=3D?=
Received: from osgeo6.osgeo.osuosl.org (HELO lists.osgeo.org) ([140.211.15.3])
  by mx201.skynet.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2021 19:46:10 +0200
Received: from osgeo6.osgeo.osuosl.org (localhost [127.0.0.1])
	by lists.osgeo.org (Postfix) with ESMTP id 1FE6C60E840C;
	Fri, 16 Apr 2021 10:46:05 -0700 (PDT)
Received: from relay3.ptmail.sapo.pt (relay3.ptmail.sapo.pt [212.55.154.23])
 by lists.osgeo.org (Postfix) with ESMTPS id 5A95E60E8406
 for <tiff@lists.osgeo.org>; Fri, 16 Apr 2021 10:46:03 -0700 (PDT)
Received: (qmail 18225 invoked from network); 16 Apr 2021 17:46:01 -0000
Received: (qmail 14044 invoked from network); 16 Apr 2021 17:46:01 -0000
Received: from unknown (HELO Sepher) (medalist@sapo.pt@[85.245.74.94])
 (envelope-sender <medalist@sapo.pt>)
 by ptmail-mta-auth02 (qmail-ptmail-1.0.0) with ESMTPSA
 for <tiff@lists.osgeo.org>; 16 Apr 2021 17:46:01 -0000
X-PTMail-RemoteIP: 85.245.74.94
X-PTMail-AllowedSender-Action: 
X-PTMail-Service: default
From: "miguel medalha" <medalist@sapo.pt>
To: <tiff@lists.osgeo.org>
Date: Fri, 16 Apr 2021 18:46:00 +0100
Message-ID: <!&!AAAAAAAAAAAYAAAAAAAAAGDYSmKIm/dOkx5/FTTl6NSCgAAAEAAAADEsoq6k64pBqnbWI0XK1XkBAAAAAA==@sapo.pt>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 14.0
Content-Language: pt
Thread-Index: Adcy6FtmMiadAGvpQxCrYbDLt9u1Cw==
Subject: [Tiff] tiffcp: LERC codec options refer to zstd even if zstd
 support is not present
X-BeenThere: tiff@lists.osgeo.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.osgeo.org>
List-Unsubscribe: <https://lists.osgeo.org/mailman/options/tiff>,
 <mailto:tiff-request@lists.osgeo.org?subject=unsubscribe>
List-Post: <mailto:tiff@lists.osgeo.org>
List-Help: <mailto:tiff-request@lists.osgeo.org?subject=help>
List-Subscribe: <https://lists.osgeo.org/mailman/listinfo/tiff>,
 <mailto:tiff-request@lists.osgeo.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: tiff-bounces@lists.osgeo.org
Sender: "Tiff" <tiff-bounces@lists.osgeo.org>

In tiffcp, the lerc help text proposes zstd compression options even if zstd
support is not present. In order to keep consistency with the other codecs,
this would need something like the following modification to 'tiffcp.c':


#ifdef LERC_SUPPORT
" -c lerc[:opts]  compress output with LERC encoding\n"
/* "    LERC options:", */
"    #            set max_z_error value\n"
"    p#           set compression level (preset)\n"
  #ifdef ZSTD_SUPPORT
    "    s#           set subcodec: 0=none, 1=deflate, 2=zstd (default 0)\n"
    "    For example, -c lerc:0.5:s2:p22 for max_z_error 0.5,\n"
    "    zstd additional compression with maximum compression level.\n"
  else
    "    s#           set subcodec: 0=none, 1=deflate (default 0)\n"
  #endif
#endif


(there was also a typo in "copression")


On the other hand, if zstd support was to be considered indispensable by the
lerc proponents, the main 'CMakeLists.txt' file should be modified as
follows:


if(ZSTD_SUPPORT)
  message(STATUS "  LERC support:                       Requested:${lerc}
Availability:${LERC_FOUND} Support:${LERC_SUPPORT}")
else
  message(STATUS "  LERC support:                       Requested:${lerc}
Availability:${LERC_FOUND} Support:${LERC_SUPPORT} (Depends on ZSTD
Support)")
endif()


What say you? Which one would be more appropriate? On a first look, I
suppose the first one, because zstd support is probably not mandatory for
lerc.



_______________________________________________
Tiff mailing list
Tiff@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/tiff
