Return-Path: <awaresystems.be+caf_=filtered=awaresystems.be@gmail.com>
Delivered-To: filtered@awaresystems.be
Received: from mx03.one.com (mx03.one.com [195.47.247.74])
	by mail6.local (Postfix) with ESMTP id 6A8638014F9F1
	for <filtered@awaresystems.be>; Tue, 17 Dec 2013 16:26:29 +0100 (CET)
X-Virus-Scanned: by one.com
Received-SPF: pass (mx03: domain of awaresystems.be+caf_=filtered=awaresystems.be@gmail.com designates 209.85.215.44 as permitted sender)
X-Greylist: whitelisted by SQLgrey-1.8.0-rc2
Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44])
	by mx03.one.com (Postfix) with ESMTP id 3A87266E965
	for <filtered@awaresystems.be>; Tue, 17 Dec 2013 15:26:29 +0000 (UTC)
Received: by mail-la0-f44.google.com with SMTP id ep20so3376154lab.31
        for <filtered@awaresystems.be>; Tue, 17 Dec 2013 07:26:29 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-original-authentication-results:delivered-to:delivered-to:date
         :from:to:in-reply-to:message-id:references:user-agent:mime-version
         :cc:subject:precedence:list-id:list-unsubscribe:list-archive
         :list-post:list-help:list-subscribe:content-type
         :content-transfer-encoding:sender:errors-to;
        bh=GmMs7ZHxAVJXbgKGJuErxVGNBby0dAOQlxGXDIBI5Tw=;
        b=LHaeTzfRaSvDr9ndYXMWqu8MpcoxubKkGYPLcBUAMIoIaaZAK8wEYoW1ZBYrU3diXs
         raIhVLpoxqDnx4JMnuzsIRZeSaM5nofs2HE0xTNy7rhpK+C7sXk08jvP9fefQ2buKk0O
         ovtEDlOBTXCH1+Nvrrmc+ksjpCbV02fCvXO0+op2Fm9sH0zJFW+YgGga/0udUkM9yGfL
         5dk07NvmPxeNxn4MRXUmZ2Exp20KsO5SGjZDdskgm8N7Uwlr/d6k2aaGP9FOuudwgUG6
         2Qhk+GfAKXf2b/QYTTXMAtlClNAwAlwwrgc0BtNHvFw/fhEqAT5aIx4Hh01tTuTKxDwp
         MjkQ==
X-Original-Authentication-Results: mx.google.com;       spf=neutral (google.com: 195.47.247.76 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mail=tiff-bounces@lists.maptools.org
X-Received: by 10.152.3.70 with SMTP id a6mr3547829laa.63.1387293988831;
        Tue, 17 Dec 2013 07:26:28 -0800 (PST)
X-Forwarded-To: filtered@awaresystems.be
X-Forwarded-For: awaresystems.be@gmail.com filtered@awaresystems.be
Delivered-To: awaresystems.be@gmail.com
Received: by 10.114.168.35 with SMTP id zt3csp802ldb;
        Tue, 17 Dec 2013 07:26:28 -0800 (PST)
X-Received: by 10.152.234.231 with SMTP id uh7mr9543558lac.10.1387293986968;
        Tue, 17 Dec 2013 07:26:26 -0800 (PST)
Authentication-Results: mx.google.com;
       spf=neutral (google.com: 195.47.247.76 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) smtp.mail=tiff-bounces@lists.maptools.org
Received-SPF: neutral (google.com: 195.47.247.76 is neither permitted nor denied by best guess record for domain of tiff-bounces@lists.maptools.org) client-ip=195.47.247.76;
Received: by 10.152.97.212 with POP3 id ec20mf1583490lab.17;
        Tue, 17 Dec 2013 07:26:26 -0800 (PST)
X-Gmail-Fetch-Info: info@awaresystems.be 1 pop.awaresystems.be 110 info@awaresystems.be
Delivered-To: info@awaresystems.be
Received: from mx05.one.com (mx05.one.com [195.47.247.76])
	by mail6.local (Postfix) with ESMTP id 898548014F9F1
	for <info@awaresystems.be>; Tue, 17 Dec 2013 15:43:54 +0100 (CET)
X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0-rc2
Received: from lists.maptools.org (ks365428.kimsufi.com [94.23.4.142])
	by mx05.one.com (Postfix) with ESMTP id 5829F429217
	for <info@awaresystems.be>; Tue, 17 Dec 2013 14:43:54 +0000 (UTC)
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id BF55235C064;
	Tue, 17 Dec 2013 09:43:08 -0500 (EST)
Received: from blade.simplesystems.org (blade.simplesystems.org [65.66.246.74])
	by lists.maptools.org (Postfix) with ESMTPS id 9273E35C064
	for <tiff@lists.maptools.org>; Tue, 17 Dec 2013 09:39:44 -0500 (EST)
Received: from freddy.simplesystems.org (freddy.simplesystems.org
	[65.66.246.65])
	by blade.simplesystems.org (8.14.4+Sun/8.14.4) with ESMTP id
	rBHEdJT0027922; Tue, 17 Dec 2013 08:39:19 -0600 (CST)
Date: Tue, 17 Dec 2013 08:39:19 -0600 (CST)
From: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
X-X-Sender: bfriesen@freddy.simplesystems.org
To: Robert Pollak <robert.pollak@jku.at>
In-Reply-To: <52B04213.5080401@jku.at>
Message-ID: <alpine.GSO.2.01.1312170833180.1717@freddy.simplesystems.org>
References: <52B04213.5080401@jku.at>
User-Agent: Alpine 2.01 (GSO 1266 2009-07-14)
MIME-Version: 1.0
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
	(blade.simplesystems.org [65.66.246.90]);
	Tue, 17 Dec 2013 08:39:19 -0600 (CST)
Cc: tiff@lists.maptools.org
Subject: Re: [Tiff] Checking the TIFFWriteScanline return value
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org

On Tue, 17 Dec 2013, Robert Pollak wrote:

> Hello list,
>
> four files in libtiff's directory 'test' seem to have the same error:
> The snippet
> 	if (!TIFFWriteScanline(tif, buf, 0, 0) < 0)
> should either be
> 	if (!TIFFWriteScanline(tif, buf, 0, 0))
> or (maybe preferably, since the return values are int: -1 or 1)
> 	if (TIFFWriteScanline(tif, buf, 0, 0) < 0)

Thanks for reporting this.  The good news is that one of the test 
programs did get it right.

I will fix this.

Bob
-- 
Bob Friesenhahn
bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
