Return-Path: <tiff-bounces@lists.maptools.org>
Delivered-To: info@awaresystems.be
Received: (qmail 32332 invoked from network); 4 Sep 2008 14:14:40 -0000
Received: from floyd.telenet-ops.be ([195.130.136.4])
          (envelope-sender <tiff-bounces@lists.maptools.org>)
          by angelia.telenet-ops.be (qmail-ldap-1.03) with SMTP
          for <info@awaresystems.be>; 4 Sep 2008 14:14:40 -0000
Received: from vijay.telenet-ops.be (vijay.telenet-ops.be [195.130.136.9])
	by floyd.telenet-ops.be (8.13.1/8.13.1) with ESMTP id m84EEegL002258
	for <info@awaresystems.be>; Thu, 4 Sep 2008 16:14:40 +0200
Received: from localhost (localhost.localdomain [127.0.0.1])
	by vijay.telenet-ops.be (Postfix) with SMTP id 88AF760005
	for <info@awaresystems.be>; Thu,  4 Sep 2008 16:14:40 +0200 (CEST)
Received: from apate.telenet-ops.be (apate.telenet-ops.be [195.130.132.43])
	by vijay.telenet-ops.be (Postfix) with ESMTP id 7F71F60004
	for <info@awaresystems.be>; Thu,  4 Sep 2008 16:14:40 +0200 (CEST)
Received: from duke.maptools.org (r153.dmsolutions.ca [209.217.116.153])
	by apate.telenet-ops.be (Postfix) with ESMTP id 1424E27EC0E
	for <info@awaresystems.be>; Thu,  4 Sep 2008 16:14:39 +0200 (CEST)
Received: from duke.maptools.org (duke.maptools.org [127.0.0.1])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id m84ECLkT014078;
	Thu, 4 Sep 2008 10:13:29 -0400
Received: from mail.sidefx.com (mail.sidefx.com [38.99.137.163])
	by duke.maptools.org (8.12.11/8.12.10) with ESMTP id m84ECHrK014075
	for <tiff@lists.maptools.org>; Thu, 4 Sep 2008 10:12:17 -0400
Received: from [192.168.235.105] (unknown [192.168.235.105])
	by mail.sidefx.com (Postfix) with ESMTP id 29B745C03E;
	Thu,  4 Sep 2008 10:12:17 -0400 (EDT)
Message-ID: <48BFECC7.7050204@sidefx.com>
Date: Thu, 04 Sep 2008 10:12:23 -0400
From: Edward Lam <edward@sidefx.com>
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
References: <5a28e8c20808111057k7bec8c86r1f56a7239d468afe@mail.gmail.com>
	<Pine.SOC.4.64.0808111422260.1107@freddy.simplesystems.org>
	<5a28e8c20808111235o3faede7o69900dc9d55633be@mail.gmail.com>
	<Pine.SOC.4.64.0808111523170.1107@freddy.simplesystems.org>
	<57562.99.237.126.63.1218501383.squirrel@www.sidefx.com>
	<Pine.SOC.4.64.0808112142330.1107@freddy.simplesystems.org>
	<48A261AF.3050109@sidefx.com>
	<Pine.SOC.4.64.0808130029570.1107@freddy.simplesystems.org>
In-Reply-To: <Pine.SOC.4.64.0808130029570.1107@freddy.simplesystems.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: tiff@lists.maptools.org
Subject: [Tiff] Re: tif_win32.c patch proposal
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-SpamCatcher-Score: 10 [X]

Seeing that there's been no movement on this patch, I've now submitted 
this under bug 1941 (http://bugzilla.maptools.org/show_bug.cgi?id=1941)

Cheers,
-Edward

Bob Friesenhahn wrote:
> On Wed, 13 Aug 2008, Edward Lam wrote:
>>> If you can submit a tested patch, I will be happy to commit it.
>>
>> Ok, here's a patch attached for discussion. The approach I previously 
>> mentioned ran into a slight snag. Once you've created an fd for a 
>> HANDLE, the C runtime library (CRT) takes ownership of it. Thus, when 
>> you call _close(fd), it closes the associated HANDLE as well. Plus, in 
>> _tiffCloseProc(), there was no way (that I found) to query the CRT to 
>> return the associated fd given the HANDLE. So in the end, I did 
>> something more drastic, albeit cleaner.
> 
> It seems that this approach is drastic enough that we should wait for 
> some feedback from potentially impacted users before moving ahead with it.
> 
> Being more from the Unix mind-set than the Windows mind-set, I like your 
> approach better than the approach which is currently used.
> 
> Bob
> ======================================
> Bob Friesenhahn
> bfriesen@simple.dallas.tx.us, http://www.simplesystems.org/users/bfriesen/
> GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/
> 

_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/
