X-Account-Key: account1
X-UIDL: e0ba0381d2ce25d5ef0a544f034fc42a
X-Mozilla-Status: 0011
X-Mozilla-Status2: 00000000
X-Mozilla-Keys:                                                                                 
Received: from lists.maptools.org (lothlorien.howardsilvan.com [127.0.0.1])
	by mail.howardsilvan.com (Postfix) with ESMTPS id E09096721BB
	for <faxguy@howardsilvan.com>; Fri, 14 Aug 2015 16:06:10 -0700 (PDT)
Received: from lists.maptools.org ([94.23.4.142] helo=lists.maptools.org)
	by lothlorien.howardsilvan.com
	with SMTP (2.3.3); 14 Aug 2015	16:06:10 -0800
Received: from [10.1.0.241] (localhost.localdomain [127.0.0.1])
	by lists.maptools.org (Postfix) with ESMTP id A364935C03C;
	Fri, 14 Aug 2015 18:05:29 -0500 (EST)
Received: from b.painless.aa.net.uk (b.painless.aa.net.uk [81.187.30.52])
	by lists.maptools.org (Postfix) with ESMTPS id A3BD735C038
	for <tiff@lists.maptools.org>; Fri, 14 Aug 2015 18:05:20 -0500 (EST)
Received: from	7.c.5.5.3.c.8.4.f.e.4.7.6.b.d.6.d.b.d.d.0.6.8.0.0.b.8.0.1.0.0.2.ip6.arpa	([2001:8b0:860:ddbd:6db6:74ef:48c3:55c7])
	by b.painless.aa.net.uk
	with esmtpsa (TLSv1:AES128-SHA:128)	(Exim 4.77) (envelope-from <rleigh@codelibre.net>)
	id 1ZQO2b-000873-CB; Sat, 15 Aug 2015 00:05:37 +0100
To: Bob Friesenhahn <bfriesen@simple.dallas.tx.us>
References: <55CCE8E5.7060405@codelibre.net>
	<alpine.GSO.2.01.1508132127010.4186@freddy.simplesystems.org>
From: Roger Leigh <rleigh@codelibre.net>
Message-ID: <55CE743A.5090003@codelibre.net>
Date: Fri, 14 Aug 2015 23:05:30 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <alpine.GSO.2.01.1508132127010.4186@freddy.simplesystems.org>
Cc: tiff@lists.maptools.org
Subject: Re: [Tiff] [patch] Additional CMake fixes (2)
X-BeenThere: tiff@lists.maptools.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: TIFF and libtiff discussion <tiff.lists.maptools.org>
List-Unsubscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=unsubscribe>
List-Archive: <http://lists.maptools.org/mailman/private/tiff>
List-Post: <mailto:tiff@lists.maptools.org>
List-Help: <mailto:tiff-request@lists.maptools.org?subject=help>
List-Subscribe: <http://lists.maptools.org/mailman/listinfo/tiff>,
	<mailto:tiff-request@lists.maptools.org?subject=subscribe>
Sender: tiff-bounces@lists.maptools.org
Errors-To: tiff-bounces@lists.maptools.org
X-Assp-ID: lothlorien.howardsilvan.com m1-93570-04835
X-Assp-Session: 207FABA0 (mail 1)
X-Assp-Detected-RIP: 2001:8b0:860:ddbd:6db6:74ef:48c3:55c7, 81.187.30.52
X-Assp-Source-IP: 2001:8b0:860:ddbd:6db6:74ef:48c3:55c7
X-Assp-Envelope-From: tiff-bounces@lists.maptools.org
X-Assp-Intended-For: faxguy@howardsilvan.com
X-Assp-Version: 2.3.3(14029) on lothlorien.howardsilvan.com
X-Assp-Server-TLS: yes
X-Assp-Delay: not delayed (whitelisted); 14 Aug 2015 16:06:10 -0800
X-Assp-Whitelisted: Yes (whitelistdb)
Return-Path: tiff-bounces@lists.maptools.org
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

On 14/08/2015 02:28, Bob Friesenhahn wrote:
> On Thu, 13 Aug 2015, Roger Leigh wrote:
>
>> Hi,
>>
>> I found that there's a copy-paste error in libtiff/CMakeLists.txt.
>> The libtiffxx logic was actually applying properties to the libtiff
>> target, which includes its linker map file and this meant that the
>> libtiff symbols were not versioned correctly and the libtiffxx symbol
>> versioning was absent entirely.
>>
>> The attached patch sets the properties on the targets correctly, and
>> so the symbol versioning should match the autotools logic now.
>
> Your patch has been applied.  Please verify.

I've checked on Ubuntu 12.04, 14.04 and 15.04 and also FreeBSD 
10.2-RELEASE (all ELF platforms) and checked the libtiff.so with objdump 
and it's matching the autoconf/make behaviour in all cases.


Regards,
Roger
_______________________________________________
Tiff mailing list: Tiff@lists.maptools.org
http://lists.maptools.org/mailman/listinfo/tiff
http://www.remotesensing.org/libtiff/


